Uploaded image for project: 'Project Configurator - Development'
  1. Project Configurator - Development
  2. PCDEV-1253

Error in ImportJobRunner Error Handling

    Details

    • Type: Bug
    • Status: Done (View Workflow)
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: 3.0.3
    • Fix Version/s: 3.0.4
    • Labels:
      None
    • Sprint:
      PC Sprint 16
    • Critical Points:
      0

      Description

      The current error handling in the method runJob in ImportJobRunner is not working properly as it catches any potential error (all Throwable) but do not verifies that every single operation executed in the error handling is done safely:

       

      catch (Throwable e) {
      // capture Throwable just in case... Sometimes while developing we might get things like
      // ClassNotDefFound errors and the like
      result.getFinalResult().setReturnCode(importProcess.getProcessErrorCode());
      Exception newExcp;
      if (e instanceof Exception)

      { newExcp = (Exception) e; }

      else

      { newExcp = new UnexpectedProjectConfigPluginException(e); }

      result.getFinalResult().addError(newExcp.getMessage(), null, newExcp);
      }

        Attachments

          Structure

            Activity

              People

              Assignee:
              jvaldeslopez Javier Valdés Lòpez
              Reporter:
              jvaldeslopez Javier Valdés Lòpez
              Votes:
              0 Vote for this issue
              Watchers:
              2 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Structure Helper Panel