Error in ImportJobRunner Error Handling

The current error handling in the method runJob in ImportJobRunner is not working properly as it catches any potential error (all Throwable) but do not verifies that every single operation executed in the error handling is done safely:

 

catch (Throwable e) {
// capture Throwable just in case... Sometimes while developing we might get things like
// ClassNotDefFound errors and the like
result.getFinalResult().setReturnCode(importProcess.getProcessErrorCode());
Exception newExcp;
if (e instanceof Exception)

{ newExcp = (Exception) e; }

else

{ newExcp = new UnexpectedProjectConfigPluginException(e); }

result.getFinalResult().addError(newExcp.getMessage(), null, newExcp);
}