Uploaded image for project: 'SR for Bitbucket - Development'
  1. SR for Bitbucket - Development
  2. SRBITB-130

Pushing tags and pushing after fast-forward merge with trusted commit authors hook blocks push

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 4.3.7
    • Labels:
      None
    • Sprint:
      Sprint 26 - Ends Aug 16, Sprint 26 - Ends Sept 1, Sprint 26 - Ends Oct 3
    • Critical Points:
      0

      Description

      git push --tags and pushing changes after a fast-forward merge does not work with the trusted commit authors hook.

      This is because the commits are empty so it goes on to compare the author with the current one and then blocks the push.

      We should check the minimal ref in the ref changes and then ignore if the type is TAG. We should also handle the merge.

        Attachments

          Issue Links

            Activity

              People

              Assignee:
              tbatagiannis Thanos Batagiannis
              Reporter:
              amarkham Adam Markham
              Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

                Dates

                Created:
                Updated:
                Resolved:

                  Time Tracking

                  Estimated:
                  Original Estimate - 4 hours
                  4h
                  Remaining:
                  Remaining Estimate - 4 hours
                  4h
                  Logged:
                  Time Spent - Not Specified
                  Not Specified