Uploaded image for project: 'SR for Bitbucket - Development'
  1. SR for Bitbucket - Development
  2. SRBITB-146

Custom web item to trigger dialog should reuse existing dialog or remove the current dialog on close

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Done
    • High
    • Resolution: Fixed
    • None
    • 4.3.7
    • None
    • Sprint 25 - Ends 2nd Aug, Sprint 26 - Ends Aug 16, Sprint 26 - Ends Sept 1, Sprint 26 - Ends Oct 3
    • 0

    Description

      This is only for the ESC key binding. The one in the footer works correctly and the one in the top right should probably be wired up manually (as its an additional one).

      We should reuse the existing dialogs on the page when triggering a dialog. Currently we render another one and forget about the existing ones already on the page.

      To reproduce:
      Setup web item to trigger dialog
      Click on web item to display dialog
      Close dialog
      Click on web item again and close dialog
      Inspect DOM and multiple dialogs are present.

      This causes problems when binding JavaScript event handlers to these dialogs when they are opened and closed.

      Attachments

        Activity

          People

            amarkham Adam Markham
            amarkham Adam Markham
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: