Uploaded image for project: 'SR for Bitbucket - Development'
  1. SR for Bitbucket - Development
  2. SRBITB-191

Trusted commit authors hook timeout when there are a large number of tags

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: 4.3.15
    • Fix Version/s: 4.3.16
    • Labels:
      None
    • Sprint:
      Sprint 27 - Ends Jan 24
    • Critical Points:
      0.9

      Description

      In SRBITB-176 we excluded tags when we read the commits in the trusted commit authors hook as they are already in the repository.

      This was to handle merges from a tag, which is quite a niche use case.

      With many thousands (11,000) of tags in the repository this causes the hook to timeout or the push takes many minutes to finish even when just pushing a single commit. It only takes a few seconds to finish when there are only a few thousand tags.

      You only really want to know if the commit exists anywhere else in the repository. Therefore we can exclude the commit if it already exists in the index. The index should in almost all cases be up to date.

        Attachments

          Activity

            People

            Assignee:
            amarkham Adam Markham
            Reporter:
            amarkham Adam Markham
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: