Uploaded image for project: 'SR for Bitbucket - Development'
  1. SR for Bitbucket - Development
  2. SRBITB-297

Size limit hook doesn't reject pushes where an oversized file was added then deleted

    XMLWordPrintableJSON

    Details

    • Type: Bug
    • Status: Done
    • Priority: High
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: 5.3.15
    • Labels:
      None
    • Sprint:
      Sprint 37 - Ends Jan 29
    • Critical Points:
      0.7

      Description

      To reproduce:

      • Set up a pre-receive hook in BB that limits the size of pushed files.
      • Add a file larger than the size limit to your local repo and commit.
      • git rm the file and commit again.
      • Push to BB.

      Expected behaviour: Push is rejected because the large file is still present in history.

      Actual behaviour: Push is allowed.

      (NB. In the case where the file was added prior to the push, and the push is just deleting it, then the hook should allow the push - and indeed it does as per SRBITB-251.)

        Attachments

          Activity

            People

            Assignee:
            rgiddings Robert Giddings
            Reporter:
            jchoules Joanna Choules
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

              Dates

              Created:
              Updated:
              Resolved: